Closed
Conversation
mateuszmlc
pushed a commit
to polybase/aztec-packages
that referenced
this pull request
Nov 3, 2025
Cleanup and simplification of cycle_group sub-classes `straus_lookup_table` and `straus_scalar_slice` - Remove Ultra/Standard conditionals - Simplify `straus_lookup_table` construction logic that was performing point additions and x-coordinate checks in two separate loops to avoid interleaving them for efficiency. We now get this for free since our circuit is automatically "sorted" by gate type (i.e. via constructing it in gate-type blocks) so we can combine what was previously two loops into one. (Note: this does not effect the number of gates but does effect the order in which they're added which in turn changes the permutation polys which is what required the vk hash update). - Remove duplicate native slices computation in `straus_scalar_slice` (since its also performed as part of the stdlib calculation)
mateuszmlc
pushed a commit
to polybase/aztec-packages
that referenced
this pull request
Nov 3, 2025
BEGIN_COMMIT_OVERRIDE chore: cycle group cleanup zkpassport#3 (AztecProtocol#16902) fix: improve polynomial structuring in translator and fix bug (AztecProtocol#16941) refactor(bb): thread chunk for better work distribution (AztecProtocol#16966) fix(bb): shell injection vectors (AztecProtocol#16958) chore: cycle group cleanup zkpassport#4 (AztecProtocol#16937) fix: use consistent default build dir in benchmark_remote.sh (AztecProtocol#17047) fix: misuse of slice() in cycle_scalar (AztecProtocol#16982) vks update docs: improve some Protogalaxy and Translator docs (AztecProtocol#17035) fix: edge case in the ECCVM related to splitting scalars (AztecProtocol#16816) update vks hash chore: return of the instance (AztecProtocol#17043) a second attempt at VK update fix: chmod +x test_civc_standalone_vks_havent_changed.sh fix avm build and update vks chore: Gemini high degree test (AztecProtocol#17055) fix: update-vk refactor(bb): Optimize interleaved polynomial batching in Gemini with parallel chunking (AztecProtocol#17049) END_COMMIT_OVERRIDE
Author
|
closed as #9 is taking over |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge 2.0.3